If if the Xbox 360 controller had been a bit smaller, it would have been nearly perfect (for me). No complaints about the overall design. The layout works well with the more modern genres, such as shooters, and they totally get bonus points for copying the lovely coloured buttons of the SNES controller. If only my tiny, childlike hands were a bit bigger...
The first three Dualshocks... Meh, they work fine, but they don't feel like they were made for human hands in general. Nice D-pad, though, and who could hate a battery life that long? I've had my DS3 for years and it still gets 40+ hours out of one charge. This is the type of controller I prefer to play my puzzle games, 2d platformers and old-school RPGs with. It doesn't work well with games that require you to use all shoulder buttons quickly and often. Shaping your hand like the claw needed to pull that off starts to hurt really fast.
I don't have much experience with the Dualshock 4 (don't have my own PS4 yet and I can't say I need one right now), but it seems to have finally fixed the Dualshocks' biggest flaw: the shitty handles.
The Cube controller is brilliant. Making the button you use the most the largest and easiest to reach makes perfect sense and the whole thing just melts into your hands. Great shape, smart layout, fun colours. Its biggest problem is that it's too brilliant. You'll need some time to get used to it if you usually use controllers with more traditional layouts. And... I have to admit I didn't care for the D-pad very much. It's too small.
What else do I like... Oh yeah, Nintendo's Classic controllers for the Wii (U) are quite nice! The simple, clean design is very stylish and they're pretty comfortable. This is what the Dualshock should have been like. Actually, there's a Wii (U) topic on a PlayStation forum I frequent and the Classics got a lot of praise over there (someone actually bought a white Wii U because he loved the design of the original classic so much, and wanted console and controller to match). I got multiple Classics myself. My first one was the white one, which I lend to one of my cousins a while ago. She uses it for her 2D platformers. I also have a red Pro and the Super Nintendo replica (LOVE IT!).
But the number one very best controller of all time and beyond is, of course:
The buttons are on its butt